Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix basic HTML highlighting #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix basic HTML highlighting #2

wants to merge 4 commits into from

Conversation

Grawl
Copy link

@Grawl Grawl commented Nov 3, 2011

I hope it will work.

@ptrm
Copy link
Owner

ptrm commented Nov 3, 2011

Hi,

Unfortunately this will break the backward-compatiblity w Espresso
1.x, and that would be bad. The second thing is, my Mac got broken and
I cannot test the changes myself.

If you could leave the deleted lines and just add the code, it should
work for both versions and look like this:

<zones> <include collection="tags" /> <include syntax="text.html.basic" /> <include syntax="language-root.html" /> </zones>

<subzones name="embedded.text.html.basic"> <include syntax="text.html.basic" /> </subzones> <subzones name="embedded.language-root.html"> <include syntax="language-root.html" /> </subzones>

@Grawl
Copy link
Author

Grawl commented Nov 3, 2011

Oh, Mac is broken…
So You suggest to just leave both pieces of code? I will try it.

@micha149
Copy link

micha149 commented Nov 3, 2011

I can try it, too. Hope your mac is up very soon.

@Grawl
Copy link
Author

Grawl commented Nov 5, 2011

I tried it and it is not a working solution. :(

@Grawl
Copy link
Author

Grawl commented Nov 5, 2011

Also. I double-checked all syntax and found that prtm's sugar is not working anymore, but earlier fork + fix in My repo is working. Check it, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants